Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gilrs 0.8.0 to gain dpad support on macos #653

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Upgrade to gilrs 0.8.0 to gain dpad support on macos #653

merged 1 commit into from
Oct 10, 2020

Conversation

CleanCut
Copy link
Member

@CleanCut CleanCut commented Oct 9, 2020

@cart I contributed dpad support for macos to gilrs. This pull request updates us to gilrs 0.8.0 to gain that new feature. AFAICT there are no breaking changes in my testing on macOS. I don't see anything else in the changelog for 0.8.0 that should be a concern.

@cart
Copy link
Member

cart commented Oct 9, 2020

Much appreciated :)

@CleanCut
Copy link
Member Author

CI froze and needs to be restarted.

@Moxinilian Moxinilian added dependencies C-Feature A new feature, making something new possible A-Input Player input via keyboard, mouse, gamepad, and more O-MacOS Specific to the MacOS (Apple) desktop operating system labels Oct 10, 2020
@cart
Copy link
Member

cart commented Oct 10, 2020

Haha ci has failed us twice now.

@cart
Copy link
Member

cart commented Oct 10, 2020

Cool looks like we have an unrelated clippy failure now from what im assuming is a clippy upgrade.

@cart
Copy link
Member

cart commented Oct 10, 2020

the fix is here: #656

We'll need to do a rebase after merging to pick up the changes.

@cart cart merged commit f6fc76d into bevyengine:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Feature A new feature, making something new possible O-MacOS Specific to the MacOS (Apple) desktop operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants